Skip to content

Add data len check in wh_CommServer_RecvRequest#389

Merged
bigbrett merged 1 commit into
wolfSSL:mainfrom
padelsbach:comm-server-req-len-check
Jun 9, 2026
Merged

Add data len check in wh_CommServer_RecvRequest#389
bigbrett merged 1 commit into
wolfSSL:mainfrom
padelsbach:comm-server-req-len-check

Conversation

@padelsbach

Copy link
Copy Markdown
Contributor

Server side companion fix to #388, with similar new length check.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #389

Scan targets checked: wolfhsm-core-bugs, wolfhsm-crypto-bugs, wolfhsm-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread src/wh_comm.c Outdated
@padelsbach padelsbach marked this pull request as ready for review May 29, 2026 21:59
@padelsbach padelsbach force-pushed the comm-server-req-len-check branch from 1c29249 to c2b5ea0 Compare May 29, 2026 22:46
Comment thread src/wh_comm.c Outdated

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #389

Scan targets checked: wolfhsm-core-bugs, wolfhsm-crypto-bugs, wolfhsm-src

No new issues found in the changed files. ✅

@AlexLanzano AlexLanzano removed their assignment Jun 9, 2026
@bigbrett

bigbrett commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@padelsbach can we get a negative test to ensure that the error check for overflow holds? Currently we only have test coverage of known good scenarios that will never actually trigger an error.

@bigbrett bigbrett merged commit c3df105 into wolfSSL:main Jun 9, 2026
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants